-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make layout supports compatible with enhanced pagination #5528
Make layout supports compatible with enhanced pagination #5528
Commits on Oct 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ec9eb66 - Browse repository at this point
Copy the full SHA ec9eb66View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4f7eab - Browse repository at this point
Copy the full SHA e4f7eabView commit details
Commits on Oct 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5468e17 - Browse repository at this point
Copy the full SHA 5468e17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d3db44 - Browse repository at this point
Copy the full SHA 2d3db44View commit details
Commits on Oct 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b6138d4 - Browse repository at this point
Copy the full SHA b6138d4View commit details -
Apply suggestions from code review
Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for 89b3ba9 - Browse repository at this point
Copy the full SHA 89b3ba9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca9731a - Browse repository at this point
Copy the full SHA ca9731aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 42035de - Browse repository at this point
Copy the full SHA 42035deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 780486b - Browse repository at this point
Copy the full SHA 780486bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11f1cac - Browse repository at this point
Copy the full SHA 11f1cacView commit details -
Run tests in separate processes.
The wp_unique_prefixed_id() function uses a function scoped static variable for memoization. The incremented value may be different between tests, especially over time when more tests are added. Running the tests in separate process improves the stability of these tests.
Configuration menu - View commit details
-
Copy full SHA for c01e7e8 - Browse repository at this point
Copy the full SHA c01e7e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c8ab55 - Browse repository at this point
Copy the full SHA 1c8ab55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a32e26 - Browse repository at this point
Copy the full SHA 7a32e26View commit details
Commits on Oct 24, 2023
-
Tests: run each dataset separately.
To avoid test order, changes to run each dataset in a separate process, which each test starts with the static `$id_counters` equal to an empty array.
Configuration menu - View commit details
-
Copy full SHA for 5aac204 - Browse repository at this point
Copy the full SHA 5aac204View commit details -
Tests: Ensure unhappy path IDs are unique.
Unhappy path tests have non-string prefixes, which will be changed to the default empty string. To further check uniqueness within the dataset's expected results, the unhappy path test now allows each dataset to specify how many unique IDs to generate for its tests.
Configuration menu - View commit details
-
Copy full SHA for f4f99fc - Browse repository at this point
Copy the full SHA f4f99fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28cbcad - Browse repository at this point
Copy the full SHA 28cbcadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92d9392 - Browse repository at this point
Copy the full SHA 92d9392View commit details -
Tests: Adds coverage for when given prefixes result in same prefix.
THis test guards against a future regression should the defensive guard ever change. Props @costdev.
Configuration menu - View commit details
-
Copy full SHA for 5151440 - Browse repository at this point
Copy the full SHA 5151440View commit details