Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make layout supports compatible with enhanced pagination #5528

Closed
wants to merge 18 commits into from
Closed

Make layout supports compatible with enhanced pagination #5528

wants to merge 18 commits into from

Commits on Oct 19, 2023

  1. Add the prefix-based unique id function

    @luisherranz
    luisherranz committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    ec9eb66 View commit details
    Browse the repository at this point in the history

  2. Use it to create the class names

    @luisherranz
    luisherranz committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    e4f7eab View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Fix failing render test

    @tellthemachines
    tellthemachines committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    5468e17 View commit details
    Browse the repository at this point in the history

  2. Add changes requested

    @cbravobernal
    cbravobernal committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    2d3db44 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Update tests, fix spacing in comment

    @cbravobernal
    cbravobernal committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    b6138d4 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Tonya Mork <tonya.mork@automattic.com>
    @cbravobernal @hellofromtonya
    cbravobernal and hellofromtonya authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    89b3ba9 View commit details
    Browse the repository at this point in the history

  3. Use isset() instead of array_key_exists()

    @hellofromtonya
    hellofromtonya authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    ca9731a View commit details
    Browse the repository at this point in the history

  4. Defensive guard for nonstring

    @hellofromtonya
    hellofromtonya committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    42035de View commit details
    Browse the repository at this point in the history

  5. Use full 6.4.0 version

    @hellofromtonya
    hellofromtonya committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    780486b View commit details
    Browse the repository at this point in the history

  6. Increment separately and then return

    @hellofromtonya
    hellofromtonya committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    11f1cac View commit details
    Browse the repository at this point in the history

  7. Run tests in separate processes. 

    The wp_unique_prefixed_id() function uses a function scoped static variable for memoization. The incremented value may be different between tests, especially over time when more tests are added.

Running the tests in separate process improves the stability of these tests.
    @hellofromtonya
    hellofromtonya committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    c01e7e8 View commit details
    Browse the repository at this point in the history

  8. Fix wpcs issues

    @hellofromtonya
    hellofromtonya committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    1c8ab55 View commit details
    Browse the repository at this point in the history

  9. Add additional happy path datasets

    @hellofromtonya
    hellofromtonya committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    7a32e26 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Tests: run each dataset separately. 

    To avoid test order, changes to run each dataset in a separate process, which each test starts with the static `$id_counters` equal to an empty array.
    @hellofromtonya
    hellofromtonya committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5aac204 View commit details
    Browse the repository at this point in the history

  2. Tests: Ensure unhappy path IDs are unique. 

    Unhappy path tests have non-string prefixes, which will be changed to the default empty string.

To further check uniqueness within the dataset's expected results, the unhappy path test now allows each dataset to specify how many unique IDs to generate for its tests.
    @hellofromtonya
    hellofromtonya committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f4f99fc View commit details
    Browse the repository at this point in the history

  3. Test: Add double dataset

    @hellofromtonya
    hellofromtonya committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    28cbcad View commit details
    Browse the repository at this point in the history

  4. Fix test dataset array => alignment

    @hellofromtonya
    hellofromtonya committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    92d9392 View commit details
    Browse the repository at this point in the history

  5. Tests: Adds coverage for when given prefixes result in same prefix. 

    THis test guards against a future regression should the defensive guard ever change.

Props @costdev.
    @hellofromtonya
    hellofromtonya committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5151440 View commit details
    Browse the repository at this point in the history