Accessibility Issue in Arranging the Menu Items #6238
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
- Dragging also updating parent and order dropdown - Changing parent also take child with it - Changing order also take child with it
|
Found it! The branch name starts with # and we didn't encode the name. |
|
@bgrgicak So do I remove the # from the branch name cause I am using it for all the branches according to ticket no. But if that solves the issue. I will update all branch names. |
|
Wrong place. I wanted to comment on this issue WordPress/wordpress-playground#1260.
No, this PR should fix it WordPress/wordpress-playground#1275 |
Updated html structure based on github request.
Fix some bugs
|
@joedolson Everything is done except item visibility. Once this commit merges, I think we can create a separate ticket to add it to the screen option. Feel free to let me know if you find any more changes. |
- Entire parent update function updated to count items properly after detaching menu item and its children and put them back to menu at defined location.
- var menuItems = $( '#menu-to-edit li' ),
^ 'menuItems' is already defined. - Removed Var from this instance
- var menuItemWithChild, menuItemNewPosition,
^ 'menuItemWithChild' is defined but never used. - Removed
- menuItemPosition = parseInt( menuItem.index(), 10 ),
^ 'menuItemPosition' is defined but never used. - Removed
- parentItemChildern = parentItem.childMenuItems(),
^ 'parentItemChildern' is defined but never used. - Removed
Forgetting Spaces :-)
|
@Rcreators I made a number of minor changes (CSS & ordering), but also made a logic change in 65b376f. I found that this logic was causing any child item that was moved to the bottom position of its menu to become a child of the next neighbor. |
|
In testing, I'm continuing to find some minor bugs in behavior with nested menus. It all seems to be the same basic problem: menus dropping to a new parent if their order is changed to the bottom of their current context. So it seems like an off-by-one type of issue. We're getting very down to the wire on shipping this in 6.7; I'll see what I can do, but might need to bump this to 6.8. |
Completely new logic with sub items list only.
|
In r59265 |
Trac ticket: https://core.trac.wordpress.org/ticket/43305
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.