-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported 'count' argument from WP_Term_Query DocBlock #6770
Remove unsupported 'count' argument from WP_Term_Query DocBlock #6770
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
8fc977d
to
4c2efa2
Compare
Hi @snehapatil2001, the PR removes the Thanks! |
Isn't that what wordpress-develop/src/wp-includes/class-wp-term-query.php Lines 315 to 324 in 4c2efa2
Also, if we're removing the doc block, we should also remove from
|
Ticket
https://core.trac.wordpress.org/ticket/61094
Description
count
argument from the DocBlock of theWP_Term_Query::__construct
method.count
argument, but it is not utilized in theWP_Term_Query::get_terms
method. This leads to potential confusion for developers.Changes Made
count
argument description from theWP_Term_Query::__construct
method's DocBlock.Context
The
WP_Term_Query
class provides methods for querying terms in WordPress. Thecount
argument was initially proposed but later removed from the code, while the DocBlock remained unchanged. This PR aligns the DocBlock with the actual code behaviour, ensuring clarity and consistency in the documentation.Testing
count
argument description is removed from theWP_Term_Query::__construct
DocBlock.WP_Term_Query
class to ensure no regressions occurred.