-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial patch for old files update for WordPress 6.7 #7594
base: trunk
Are you sure you want to change the base?
Initial patch for old files update for WordPress 6.7 #7594
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterwilsoncc Thanks! Looks good so far! Nice to have an early PR to have other folks review.
We'll rerun the ^D
and ^A
during the Dry Run to make sure the updates here are still the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I compared this list of deleted files/dirs against the list generated by WP_CLI when upgrading from 6.6.2 to 6.7-beta3 and they are consistent.
By consistent I mean that WP_CLI deletes individual files like wp-includes/SimplePie/{dir}/{file} and this patch deletes wp-includes/SimplePie/{dir}.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary, but wouldn't hurt to add a reference to https://core.trac.wordpress.org/changeset/59141 in this comment.
Proposed commit message:
|
I now realize I did something wrong. I meant the above to be "add that reference to comment at the being of the PR that explains about the SimplePie update" ;-) |
14fe88d
to
5e907a3
Compare
Yes, that makes way more sense. Pushed. It's early, that's my excuse for misunderstanding ;) |
Trac ticket: https://core.trac.wordpress.org/ticket/62150
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.