Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: fix use of deprecated set-output #136

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Oct 14, 2022

GitHub has deprecated the use of set-output (and set-state) in favour of new environment files.

This commit updates workflows to use the new methodology.

Refs:

@jrfnl jrfnl force-pushed the feature/ghactions-dont-use-set-output branch from d647a60 to 77f5fe4 Compare April 5, 2023 06:14
@jrfnl jrfnl force-pushed the feature/ghactions-dont-use-set-output branch from 77f5fe4 to 871b04c Compare December 27, 2023 07:30
Copy link
Contributor

@ouikhuan ouikhuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GitHub has deprecated the use of `set-output` (and `set-state`) in favour of new environment files.

This commit updates workflows to use the new methodology.

Refs:
* https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
* https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files
@jrfnl jrfnl force-pushed the feature/ghactions-dont-use-set-output branch from 871b04c to f5d355a Compare January 4, 2024 07:50
@jrfnl
Copy link
Member Author

jrfnl commented Jan 4, 2024

As the build is now passing, I will merge this as otherwise we'll have failing builds again once GH completely stops supporting set-output.

@jrfnl jrfnl merged commit 6452f7c into master Jan 4, 2024
22 checks passed
@jrfnl jrfnl deleted the feature/ghactions-dont-use-set-output branch January 4, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants