Tests_Import_Parser::test_blank_lines_in_content(): minor test fix #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on how a git repo is cloned, files may have *nix line endings or Windows line endings. Now, as this test uses a file based fixture, this has an impact on the tests. As things are, the test basically assumes that `core.autocrlf=true` (change line endings based on the OS) is used, while that is an assumption which cannot be made. This can lead to confusion for contributors when they are confronted by an inexplicably failing test. As the Windows line ending `\r\n` includes the *nix line ending `\n` anyway, changing the test to just check for the count of the `\n` characters maintains the value of the test, while preventing test failures for contributors who run the test on Windows and check out with `core.autocrlf=input`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on how a git repo is cloned, files may have *nix line endings or Windows line endings. Now, as this test uses a file based fixture, this has an impact on the tests.
As things are, the test basically assumes that
core.autocrlf=true(change line endings based on the OS) is used, while that is an assumption which cannot be made.This can lead to confusion for contributors when they are confronted by an inexplicably failing test.
As the Windows line ending
\r\nincludes the *nix line ending\nanyway, changing the test to just check for the count of the\ncharacters maintains the value of the test, while preventing test failures for contributors who run the test on Windows and check out withcore.autocrlf=input.