Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer: update to WordPressCS 3.
Composer:
PHPCS ruleset:
Refs:
CS/QA: all methods should have visibility declared
To prevent any BC-breaks, all methods without explicit visibility have now been explicitly declared as
public
.Mind: the
set_up()
andtear_down()
methods in the tests should beprotected
, but as WP Core didn't always have this correct and this plugin still supports a large range of WP versions, so needs to take a large range of WP versions into account for the WP Core test framework on which the test suite is build, setting the visibility topublic
is the safer choice for now.CS/QA: all properties should have visibility declared
To prevent any BC-breaks, all properties without explicit visibility have now been explicitly declared as
public
.CS: always use parentheses for class instantiation
CS/QA: don't use reserved keywords as parameter names
... to prevent code getting really confusing when people would call it using PHP 8.0+ function calls with named arguments.
Modernize: use the magic DIR constant
CS/QA: miscellaneous other fixes
require
for unconditional file includes.