Skip to content

Commit

Permalink
Local navigation bar block: Remove default background color property.
Browse files Browse the repository at this point in the history
The custom color is set using `style.color.background`, not `backgroundColor`. So when using a custom color, technically there is no `backgroundColor` attribute. The change to correctly inherit default attribute values was then setting a backgroundColor, which the color block-support prioritizes when building the style code, overriding the custom color.

This default can be removed, the CSS applies the blueberry color if no other colors are set.

Fixes #654
  • Loading branch information
ryelle committed Sep 26, 2024
1 parent b1e4106 commit e2c61f7
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions mu-plugins/blocks/local-navigation-bar/src/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
"default": "full"
},
"backgroundColor": {
"type": "string",
"default": "blueberry-1"
"type": "string"
},
"layout": {
"type": "object",
Expand Down

0 comments on commit e2c61f7

Please sign in to comment.