Avoid nullable schemaPath
and instancePath
#197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
schemaPath
andinstancePath
onValidationError
is nevernull
, so users shouldn't need to check fornull
.How it was fixed:
schemaPath
andinstancePath
was made non-nullable.Testing suggestions:
N/A.
Potential areas of regression:
nits:
schemaPath
orinstancePath
may get a warning, if they were doing null checks (most probably where). This warning is likely harmless and easy to fix by removing the unnecessary null check.ValidationError
may rely oninstancePath
andschemaPath
being nullable.However:
ValidationError
is common (the constructor is private, so it was probably not intended for subclassing).ValidationError
should probably be a made afinal class ValidationError
.