Avoid empty instancePath when propertyNames is violated
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `_validate` take an `Instance` object instead of dynamic. And instead forces the callers to convert any values to `Instance` objects. This is probably a good idea because: * Caller is the only one who can construct the `instancePath`. * It avoids a lot of unnecessary `instance is! Instance` checks. Fixing this it was discovered that `propertyNames` errors were reported with an empty `instancePath`. Which could cause confusion for anyone trying to display the error.
|
QA +1
@jonasfj Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
When validating a schema with the
propertyNamesapplicator any errors produced had an emptyinstancePath.How it was fixed:
This makes
_validatetake anInstanceobject instead of dynamic. And instead forces the callers to convert any values toInstanceobjects.This is probably a good idea because:
instancePath.instance is! Instancechecks 🚀While fixing this I discovered that
propertyNameserrors were reported with an emptyinstancePath. Which could cause confusion for anyone trying to display the error.Testing suggestions:
Test case included in PR.
Potential areas of regression:
Anyone depending on current behavior could be affected.
Most likely an empty
instancePathis not what anyone is expecting.