Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA-2879: Include SockJS debug URL #415

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Nov 1, 2023

Motivation

We need a way to pipe the websocket debug url to consumers

Changes

  • Add debugUrl to WebSocketConnectEvent which is emitted via the
    GlobalWebSocketMonitor. When using SockJS, this will be populated with the
    full URL that the underlying transport is using, which can be useful information
    for debugging.

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Architecture member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@corwinsheahan-wf corwinsheahan-wf marked this pull request as ready for review November 3, 2023 18:28
@corwinsheahan-wf corwinsheahan-wf changed the title Include SockJS debug URL FEA-2879: Include SockJS debug URL Nov 3, 2023
@corwinsheahan-wf
Copy link
Contributor

QA +1
Pulled this into wdesk and verified that the transport url is logged

Merging into master.
@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit a8ad318 into master Nov 3, 2023
2 checks passed
@rm-astro-wf rm-astro-wf deleted the include-sockjs-debug-url branch November 3, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants