drop zoom oauth refresh token #819
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlorper
approved these changes
Oct 7, 2024
aperez-worklytics
approved these changes
Oct 14, 2024
|
|
||
| lifecycle { | ||
| ignore_changes = [ | ||
| value, # key difference here; we don't want to overwrite values filled by the external process | ||
| insecure_value, |
There was a problem hiding this comment.
What happens if for example client_id is wrongly provided if is not sensitive? Does value will update insecure_value on second attempt ?
There was a problem hiding this comment.
if this is in lifecycle, then TF shouldn't change resource even if it believes changes are needed in EITHER value or insecure_value
| @@ -81,3 +81,21 @@ sufficient, but as of May 2024 are no longer available for newly created Zoom ap | |||
| Once the scopes are added, click on `Done` and then `Continue`. | |||
|
|
|||
| 6. Activate the app | |||
There was a problem hiding this comment.
Maybe you can include an screenshot like this on this step too:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Fixes
Stringrather thanSecureStringusedTODO
Change implications