Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix path urldecoding via api gw v2 #827

Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix path urldecoding via api gw v2 #827

merged 3 commits into from
Oct 28, 2024

Conversation

eschultink
Copy link
Member

@eschultink eschultink commented Oct 24, 2024 •
edited
Loading

Fixes

  • API gateway v2 seems to decode paths, causing any url encoding of fragments to be lost before transfer to source; eg, client sends /foo%25bar/; then the proxy sees /foo/bar/, and will forward that as such to server

Change implications

  • dependencies added/changed? no
  • something important to note in future release notes? slight behavior change ...

@eschultink eschultink self-assigned this Oct 24, 2024
@eschultink eschultink marked this pull request as ready for review October 28, 2024 21:23
@eschultink eschultink merged commit 5b63713 into rc-v0.5.0 Oct 28, 2024
27 checks passed
@eschultink eschultink deleted the s186-fix-path-urldecoding-via-api-gw-v2 branch October 28, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aperez-worklytics aperez-worklytics aperez-worklytics approved these changes

@jlorper jlorper Awaiting requested review from jlorper

Assignees

@eschultink eschultink

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eschultink @aperez-worklytics