Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teams with default scopes #833

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

aperez-worklytics
Copy link
Contributor

msft-teams should use azure-ad as default scope, but it was using a deprecated property on that and no value was provided, leaving it as the same as source.

Fixes

Psoxy: msft-teams scope

Features

paste links to issues/tasks in project management

Change implications

  • dependencies added/changed? no
  • something important to note in future release notes?
    • NOTE in CHANGELOG.md anything that will show up in terraform plan/apply that isn't
      obviously a no-op?
    • breaking changes? if in module/example that is NOT marked alpha, requires major version
      change

Copy link
Member

@eschultink eschultink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - this is fine; although it shouldn't affect behavior of proxy for anyone not using LEGACY pseudonyms

@eschultink eschultink merged commit 6b0d72e into rc-v0.4.62 Nov 12, 2024
66 checks passed
@eschultink eschultink deleted the fix_msft_teams_scope branch November 12, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants