Skip to content

Commit

Permalink
added comments on processing extent
Browse files Browse the repository at this point in the history
  • Loading branch information
jdegerickx committed Jul 5, 2024
1 parent a071e05 commit 6a0feef
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
6 changes: 5 additions & 1 deletion notebooks/system_v1_custom_models_private_data.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@
"# retrieve bounding box from drawn rectangle\n",
"from worldcereal.utils.map import get_bbox_from_draw\n",
"\n",
"spatial_extent, bbox, poly = get_bbox_from_draw(dc)\n"
"spatial_extent, bbox, poly = get_bbox_from_draw(dc)\n",
"\n",
"#TODO: relax processing area limit but raise a warning containing an estimate on processsing credits consumption for large areas?"
]
},
{
Expand Down Expand Up @@ -320,6 +322,8 @@
"# OR move this functionality to src\n",
"# and remove the point_extractions functionality from utils\n",
"\n",
"#TODO: issue warning whenever user is about to launch A LOT OF extractions!\n",
"\n",
"from utils import point_extractions\n",
"\n",
"#TODO: make output path customizable\n",
Expand Down
6 changes: 4 additions & 2 deletions notebooks/system_v1_inference.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@
],
"source": [
"# retrieve bounding box from drawn rectangle\n",
"spatial_extent, bbox, poly = get_bbox_from_draw(dc)"
"spatial_extent, bbox, poly = get_bbox_from_draw(dc)\n",
"\n",
"#TODO: relax processing area limit but raise a warning containing an estimate on processsing credits consumption for large areas?"
]
},
{
Expand Down Expand Up @@ -513,7 +515,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.9"
"version": "3.1.-1"
}
},
"nbformat": 4,
Expand Down
4 changes: 3 additions & 1 deletion notebooks/system_v1_inference_extended.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,9 @@
],
"source": [
"# retrieve bounding box from drawn rectangle\n",
"spatial_extent, bbox, poly = get_bbox_from_draw(dc)"
"spatial_extent, bbox, poly = get_bbox_from_draw(dc)\n",
"\n",
"#TODO: relax processing area limit but raise a warning containing an estimate on processsing credits consumption for large areas?"
]
},
{
Expand Down

0 comments on commit 6a0feef

Please sign in to comment.