Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8a2ab3cac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Create and push tag | ||
| run: | | ||
| git tag "v${{ steps.release_version.outputs.value }}" | ||
| git push origin main --follow-tags |
There was a problem hiding this comment.
Restrict releases to main or push HEAD explicitly
This workflow can be manually dispatched from any branch, but the push step always runs git push origin main --follow-tags; when dispatched from a non-main ref, the release commit is created on the checked-out ref and then not pushed, so the version/changelog changes used to build the release are missing from main. This can produce a release/tag that does not correspond to the committed release metadata unless you either gate the job to refs/heads/main or push HEAD:main.
Useful? React with 👍 / 👎.
| git tag "v${{ steps.release_version.outputs.value }}" | ||
| git push origin main --follow-tags |
There was a problem hiding this comment.
Push the new tag explicitly after creating it
The step creates a tag with git tag "v..." (lightweight tag) and then relies on git push ... --follow-tags; this does not reliably publish that newly created tag, so if the later action-gh-release step fails, the repository can end up with a release commit pushed but no remote vX.Y.Z tag. Push the tag directly (for example git push origin "v...") or create an annotated tag and push it.
Useful? React with 👍 / 👎.
Summary
.github/workflows/release-automation.yml(manual dispatch)scripts/release_automation.pyfor semver bump + changelog section cutCHANGELOG.mdintoRELEASE_NOTES.mdvX.Y.Z), push, and GitHub Release creationdocs/release-automation.mdand link from README/checklistValidation