cleanup: __FUNCTION__ -> __func__ #1338
Open
+31
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we really consider |
Contributor
Author
I personally don't think we should rely on the GNU extensions so that we can use quick compilers for development like TCC and build releases with GCC if desired, but thats just my opinion. I do think some of the pedantic warnings are a bit heavy handed (anonymous structs are flagged but are later supported in C11), but this is a bit of housekeeping that I think lets our code be more portable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes about 400 lines of -Wpedantic complaining, this is a useless gnuism, as the c99 standard func does the exact same thing as FUNCTION