treewide: drop ifdef's for GLYPHPADBYTES != 4 #1348
+1
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's always defined to 4, for over a decade now, so no extra case checks needed anymore. See: 17c3347 Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
metux
requested review from
a team,
ONykyf,
algrid,
b-aaz,
callmetango,
cepelinas9000,
jonhermansen,
josephcrowell,
mikedld and
stefan11111
metux
added a commit
that referenced
this pull request
Nov 7, 2025
metux
added a commit
that referenced
this pull request
Nov 7, 2025
metux
added a commit
that referenced
this pull request
Nov 7, 2025
|
Apparently the value was supposed to be chosen as the most suitable for a given architecture. But then someone decided (in fb.h) that it can only be 4. I wonder why? And wouldn’t it be good to make it 8 for modern 64-bit architectures? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's always defined to 4, for over a decade now, so no extra case
checks needed anymore.
See: 17c3347
Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net