os: replace ETEST macro by ossock_wouldblock() #1364
Merged
+21
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metux
requested review from
a team,
ONykyf,
algrid,
b-aaz,
callmetango,
cepelinas9000,
jonhermansen,
josephcrowell,
mikedld and
stefan11111
metux
added a commit
that referenced
this pull request
Nov 7, 2025
metux
added a commit
that referenced
this pull request
Nov 7, 2025
stefan11111
reviewed
Nov 7, 2025
| todo = notWritten; | ||
| } | ||
| else if (ETEST(errno) | ||
| #ifdef EMSGSIZE /* check for another brain-damaged OS bug */ |
Contributor
There was a problem hiding this comment.
Could you keep this and the comment, if we're keeping the EMSGSIZE test?
Also, what os fails with EMSGSIZE on tcp/unix socket reads?
Contributor
Author
There was a problem hiding this comment.
removed that entirely. couldn't find any OS (supported by us) that's returning EMSGSIZE on stream sockets.
Move this to a little function (which also has a better name now) inside the already platform specific ossock.c Also removing the EMSGSIZE check: we're using TCP or local unix socket, so EMSGSIZE is never returned. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
metux
force-pushed
the
pr/os-replace-etest-macro-by-ossock-wouldblock-_2025-11-07_16-07-44
branch
from
83e1da5 to
8f039cc
Compare
metux
added a commit
that referenced
this pull request
Nov 7, 2025
metux
added a commit
that referenced
this pull request
Nov 7, 2025
stefan11111
approved these changes
Nov 7, 2025
metux
deleted the
pr/os-replace-etest-macro-by-ossock-wouldblock-_2025-11-07_16-07-44
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move this to a little function (which also has a better name now)
inside the already platform specific ossock.c
Signed-off-by: Enrico Weigelt, metux IT consult info@metux.net