Replace cryptography with hashlib #278
Conversation
Cryptography uses rust as engine. This can lead to trouble when trying to build this package for arm/v7 as cryptography as no prebuilt binaries for this platform. In general, this will help with cross compatibility across architectures. Also it was needed, when i tried to build a docker image of an app using xknxproject as a lib. cross building for linux/arm/v7 would always fail in this case due to having to setup a rust compiler and not succeeding to do so.
feat(Deps): Replace crytpography with hashlib
Codecov Report
@@ Coverage Diff @@
## main #278 +/- ##
==========================================
- Coverage 97.34% 97.34% -0.01%
==========================================
Files 21 21
Lines 943 942 -1
==========================================
- Hits 918 917 -1
Misses 25 25
|
|
Hi 👋! What is your use case for xknxproject on 32bit Arm? |
There was a problem hiding this comment.
Oh dear, I didn't notice that hashlib is part of pythons standard library. So this actually reduces dependencies.
And is even faster than the cryptography implementation on a quick test I made on 1 machine 🙃 (not that it matters for this use case here 😛). Probably due to overhead, as both are using OpenSSL afaik
Deprecated since version 3.10: Slow Python implementation of pbkdf2_hmac is deprecated. In the future the function will only be available when Python is compiled with OpenSSL.
Anyway, I think this is a good idea! Thank you very much 👍
|
I am very happy that my PR was merged. Totally forgot to mention that I just removed these deps without adding a new one. Not every wheel is available for arm. Image build now takes a lot of time, again, no prebuilt wheel for pyzipper, but it is based on C, so I can build it fine, it just takes a full 10 minutes to build the image.... But at least it builds and runs. Thank you for the work on this, I made my own .knxproj parser in Go a while back... Yours works wayyy better :) |
I had issues trying to build a Docker image form linux/arm/v7 that runs a http server using your library. This was due to the fact that cryptography does not have prebuilt binaries for armv7, and it needs to be compiled during he pip install phase.
Problem is that it also needs a rust compiler to do so (as cryptography uses rust), and after trying for two days, I was not able to install it in the image and buid cryptography in the image.
Also cryptography is only used in a small portion of the code, and I figured switching to hashlib will lead to an improved cross architecture compatibily and improve my own workflow (which is cross compiling docker images) but also, and I hope, others workflow.