Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit channel name from application channel #462

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

farmio
Copy link
Member

@farmio farmio commented Sep 13, 2024

if not found in project data (0.xml).

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.26%. Comparing base (2b0e99a) to head (9e99792).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xknxproject/models/models.py 86.36% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
- Coverage   97.38%   97.26%   -0.12%     
==========================================
  Files          22       22              
  Lines        1184     1206      +22     
==========================================
+ Hits         1153     1173      +20     
- Misses         31       33       +2     
Files with missing lines Coverage Δ
xknxproject/loader/application_program_loader.py 100.00% <100.00%> (ø)
xknxproject/loader/project_loader.py 98.20% <100.00%> (+0.01%) ⬆️
xknxproject/models/__init__.py 100.00% <ø> (ø)
xknxproject/util.py 100.00% <100.00%> (ø)
xknxproject/models/models.py 97.12% <86.36%> (-0.45%) ⬇️

@farmio farmio merged commit e26a3ca into main Sep 13, 2024
6 of 8 checks passed
@farmio farmio deleted the channel-name-inherit branch September 13, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant