Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ETS 4.1 project files #476

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Support ETS 4.1 project files #476

merged 1 commit into from
Oct 6, 2024

Conversation

farmio
Copy link
Member

@farmio farmio commented Oct 6, 2024

ETS 4.1.6 (Build 3250) seems to use the same schema version as 4.1 (Version 11), but the knx_master.xml lacks the <?xml version="1.0" encoding="UTF-8"?> first line. So we have to check first and second line for the namespace (we skipped first line previously).

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.37%. Comparing base (dfcccc3) to head (726f4ab).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   95.37%   95.37%           
=======================================
  Files          22       22           
  Lines        1275     1276    +1     
=======================================
+ Hits         1216     1217    +1     
  Misses         59       59           
Files with missing lines Coverage Δ
xknxproject/const.py 100.00% <100.00%> (ø)
xknxproject/zip/extractor.py 91.95% <100.00%> (+0.09%) ⬆️

@farmio farmio merged commit 02f86a1 into main Oct 6, 2024
8 checks passed
@farmio farmio deleted the ets_4.1 branch October 6, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant