Include the row number in the error message

XLSForm · Sep 25, 2023 · d2a6827 · d2a6827
1 parent c3d0f2c
commit d2a6827
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/pyxform/xls2json.py b/pyxform/xls2json.py
@@ -1342,7 +1342,10 @@ def workbook_to_json(
                         new_dict["control"] = new_dict.get("control", {})
                         new_dict["control"].update({"intent": app_package_name})
                     else:
-                        raise PyXFormError("Invalid Android package name format.")
+                        raise PyXFormError(
+                            (ROW_FORMAT_STRING % row_number)
+                            + " Invalid Android package name format."
+                        )
 
             parent_children_array.append(new_dict)
             continue

diff --git a/tests/test_image_app_parameter.py b/tests/test_image_app_parameter.py
@@ -30,7 +30,7 @@ def test_throwing_error_when_invalid_android_package_name_is_used(self):
         |        | type   | name     | label | parameters      | appearance |
         |        | image  | my_image | Image | app=something   | {case}     |
         """
-        error__contains = (["Invalid Android package name format"],)
+        error__contains = (["[row = 2] Invalid Android package name format"],)
         for case in appearances:
             with self.subTest(msg=case):
                 self.assertPyxformXform(