New non-text calculations output a missing-label warning

[MartijnR]

I think these warnings are no longer helpful, in the forthcoming release that includes non-text calculations.

Example:

type	name	label	hint	calculation
dateTime	a			now()
integer	b			1 div 1
note	note	Hello World

XLSForm

Outputs (in latest master):

Warnings:
[row : 2] Question has no label: {'type': 'dateTime', 'name': 'a', 'bind': {'calculate': 'now()'}}
[row : 3] Question has no label: {'type': 'integer', 'name': 'b', 'bind': {'calculate': '1 div 1'}}

The warning remains helpful:

• if the question has no value in the calculation column and has no dynamic default value, as in example below:

type	name	label	hint
dateTime	a
integer	b

[pbowen-oc]

The current error messages are preventing forms form being uploaded as expected. Since old-style calculate items are also required to have a calculation, this is preventing forms from having non-visible items with default values that can be utilized by other items on the form in their default value expressions. Note that default values expressions that reference calculated values don't seem to work since the calculations are not performed prior to the default value expressions being evaluated.

[MartijnR]

Since old-style calculate items are also required to have a calculation

I added a separate issue for this: #454

Note that default values expressions that reference calculated values don't seem to work since the calculations are not performed prior to the default value expressions being evaluated.

Added a documentation issue for this: XLSForm/xlsform.github.io#204 Maybe one day we could show a warning in pyxform for this as that would be ideal.

[pbowen-oc]

@gushil - Can you work on this?

@MartijnR - Should the warning be based on not having a label or based on not having a label or hint? I thought it was permitted to have an item in the UI with no label if it had a hint?

[MartijnR]

Great, thanks!

Should the warning be based on not having a label or based on not having a label or hint? I thought it was permitted to have an item in the UI with no label if it had a hint?

Yes, that's right, that is permitted. I think that part of the logic in pyxform can remain unchanged. We just need to omit the warning(s) we currently have for missing label (and hint), if a dynamic default is present.

[gushil]

@pbowen-oc I'm working on this.
@MartijnR I've created PR #458 to address this issue.