Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed new non-text calculations output a missing-label warning #458

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Fixed new non-text calculations output a missing-label warning #458

merged 2 commits into from
Jul 23, 2020

Conversation

gushil
Copy link
Contributor

@gushil gushil commented Jul 17, 2020

Closes #
#451

Why is this the best possible solution? Were any other approaches considered?

The simplest one.

What are the regression risks?

None.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

None.

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests_v1
  • run nosetests and verified all tests pass
  • run black pyxform to format code
  • verified that any code or assets from external sources are properly credited in comments

@gushil
Copy link
Contributor Author

gushil commented Jul 17, 2020

@MartijnR I haven't added any test cases for this issue yet because I couldn't find a way to test warning yet. Do you have any suggestions about that?

Thanks

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2020

Codecov Report

Merging #458 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   83.11%   83.11%           
=======================================
  Files          25       25           
  Lines        3595     3595           
  Branches      833      833           
=======================================
  Hits         2988     2988           
  Misses        460      460           
  Partials      147      147           
Impacted Files Coverage Δ
pyxform/xls2json.py 78.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0bd9d4...d985cf7. Read the comment docs.

@MartijnR
Copy link
Contributor

Thanks! I'll do some testing. Wrt to testing for warnings, see example here: https://github.com/XLSForm/pyxform/blob/master/pyxform/tests_v1/test_dynamic_default.py#L310-L316

@MartijnR
Copy link
Contributor

I did not find issues with the functionality.

@gushil
Copy link
Contributor Author

gushil commented Jul 20, 2020

@MartijnR I'm adding some tests.

Thanks.

@MartijnR MartijnR requested a review from lognaturel July 20, 2020 19:11
@lognaturel lognaturel merged commit 0d53f40 into XLSForm:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants