dev: update dependencies, testing, packaging, and linting/formatting #685
Commits on Feb 8, 2024
-
dev: update dev dependencies and build process to current fashion
- config: old [setup.cfg, setup.py], new [pyproject.toml] - format/lint: old [black, flake8, isort], new [ruff] - build/publish: old [build, twine], new [flit] - updated github actions and readme accordingly - source changes according to new default formatter and linter rules
-
dev: remove unused and unmaintained sphinx dev docs stub
- nobody has changed these files since 2011, and they're very incomplete - the docs generated aren't published anywhere - the readme instructions don't work with python 3.8 - sphinx 1.0.7 not compatible with python 3+ - newer sphinx versions have an OS dependency on OpenSSL 1.1.1+ - updated readme to refer to useful resources and current docs state
-
dev: fix linter warnings from flake8-bugbear rules
- mostly error handling, unused variables
-
dev: fix linter warnings from ruff-specific rules
- mostly mutable classvars, unnecessary noqa comments, list unpacking
-
dev: fix linter warnings from flake8-comprehensions rules
- unnecessary calls to list() or dict(), redundant comprehensions
-
dev: fix linter warnings from perflint and flake8-pie rules
- unnecessary placeholders, unnecessary range starts (0), dict.values() - re-order ruff calls since `check` doesn't auto-format
-
dev: fix linter warnings from pylint rules
- collapsible else-ifs, collapsible multiple comparisons
-
dev: fix linter warnings from flake8-bandit rules
- use of assert, use of ElementTree, unchecked URL scheme
-
dev: fix linter warnings from flake8-pyi, tryceratops rules
- use type-able NamedTuple, raise accurate errors, log exception TBs
-
dev: fix linter warnings from pyupgrade rules
- UP009 utf8-encoding-declaration unnecessary for python 3
-
-
-
dev: fix linter warnings from pyupgrade rules
- UP031 printf-string-formatting replace percent-formats with f-strings
-
dev: rename test modules/methods for unittest runner instead of nose
- nose 1.3.7 is very old and not using any advanced test features that would require a 3rd party test library like nose2 or pytest - default pattern is test_* for runner to pick up TestCases
-
dev: update usages of codecs.open to use underlying built-in
- remove redundant mode/encoding args - simplify unittest import in test_bugs.py
-
dev: fix ResourceWarning during tests, broken test, string formatting
- xls2json_backends.py: both XLS and XLSX open and read the respective files, do processing, then close the file. But if an error occurs during processing then the file is left open. A ResourceWarning is raised when python cleans up the file handle. The ResourceWarning is visible during tests because test libraries remove the normal suppression of warnings during test runs. So normally a user probably wouldn't see it. The fix is to make sure the workbook object and file are cleaned up and closed with a contextmanager + try-except block. - test_bugs.py: fixed test that had been broken for a while. It was not being executed by nose test runner for some reason. After converting tests to unittest, it ran and failed. After doing some git archaeology it seems that the 3rd warning that was expected was one about Google Sheets not supporting certain file names, but while that warning was later removed, the test was not updated. The 2nd is commented on. - fixed strange string concatentation on the same line e.g. "a" "b".
-
dev: fix expected output in attribute_columns_test
- nose tests were not running this test for a while. The changes are: - secondary instances / itemsets replacing inline choices. - for media itext with no translation, the value/form not output - probable bug: custom attributes not applied to repeat template (they appear in first repeat but not the jr:template). -
- bump actions version numbers - update syntax for install, build, test
-
dev: add encoding to open() calls for cross-platform test compatibility
- either missing before, or mistakenly removed in commit f491ea8
-
-
-
dev: move binding_conversion dict to aliases, remove irrelevant comment
- feedback from PR XLSForm#685
