-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PermissionedDomain support for MPTs. #263
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @Tapanito !
|
I think it's important to be careful/explicit about dependencies among multiple amendments like this. What happens if MPT support is enabled on a given network and Permissioned Domains aren't? |
Actually, let me take this a step further and say: THIS SHOULD NOT BE MERGED AS-IS. The MPTokensV1 amendment is already open for voting in a released stable version of the So any change to this spec should make it clear which amendment gates the addition/change to the spec. |
No description provided.