Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include index in server_definitions RPC #5190

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Nov 12, 2024

High Level Overview of Change

This PR re-adds the "index" field to the server_definitions RPC, and adds some tests to ensure this is caught in the future.

Context of Change

#5122 removed sfIndex, which had the side effect of removing that field from the server_definitions RPC, and this broke client libraries.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

API Impact

  • Bugfix
  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (9d58f11) to head (8ee6f31).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5190     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          782     782             
  Lines        66616   66620      +4     
  Branches      8161    8137     -24     
=========================================
- Hits         51902   51897      -5     
- Misses       14714   14723      +9     
Files with missing lines Coverage Δ
src/libxrpl/protocol/SField.cpp 79.1% <ø> (ø)

... and 6 files with indirect coverage changes

Impacted file tree graph

@mvadari mvadari added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Nov 12, 2024
@kennyzlei kennyzlei added this to the 2.3.0 (Nov 2024) milestone Nov 12, 2024
@ximinez ximinez added the Perf impact not expected Change is not expected to improve nor harm performance. label Nov 12, 2024
@ximinez ximinez merged commit 8186253 into XRPLF:develop Nov 12, 2024
17 of 18 checks passed
@ximinez ximinez mentioned this pull request Nov 12, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. Perf impact not expected Change is not expected to improve nor harm performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants