-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for NetworkID #461
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1276c74
update definitions.json
nkramer44 c6fe39c
add NetworkId wrapper class, and add NetworkId as an Optional field i…
nkramer44 ff37c4c
add network_id to ServerInfo
nkramer44 fbef450
remove old codec fields from data-driven-tests.json
nkramer44 2bcd1ec
Merge branch 'main' into nk/network-id
nkramer44 5b6e7c9
pr feedback
nkramer44 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/jackson/modules/NetworkIdDeserializer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
package org.xrpl.xrpl4j.model.jackson.modules; | ||
|
||
/*- | ||
* ========================LICENSE_START================================= | ||
* xrpl4j :: core | ||
* %% | ||
* Copyright (C) 2020 - 2023 XRPL Foundation and its contributors | ||
* %% | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* =========================LICENSE_END================================== | ||
*/ | ||
|
||
import com.fasterxml.jackson.core.JsonParser; | ||
import com.fasterxml.jackson.databind.DeserializationContext; | ||
import com.fasterxml.jackson.databind.deser.std.StdDeserializer; | ||
import com.google.common.primitives.UnsignedInteger; | ||
import org.xrpl.xrpl4j.model.transactions.NetworkId; | ||
|
||
import java.io.IOException; | ||
|
||
/** | ||
* Custom Jackson deserializer for {@link NetworkId}s. | ||
*/ | ||
public class NetworkIdDeserializer extends StdDeserializer<NetworkId> { | ||
|
||
/** | ||
* No-args constructor. | ||
*/ | ||
public NetworkIdDeserializer() { | ||
super(NetworkId.class); | ||
} | ||
|
||
@Override | ||
public NetworkId deserialize(JsonParser jsonParser, DeserializationContext ctxt) throws IOException { | ||
return NetworkId.of(UnsignedInteger.valueOf(jsonParser.getValueAsLong())); | ||
} | ||
} |
46 changes: 46 additions & 0 deletions
46
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/jackson/modules/NetworkIdSerializer.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
package org.xrpl.xrpl4j.model.jackson.modules; | ||
|
||
/*- | ||
* ========================LICENSE_START================================= | ||
* xrpl4j :: core | ||
* %% | ||
* Copyright (C) 2020 - 2023 XRPL Foundation and its contributors | ||
* %% | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* =========================LICENSE_END================================== | ||
*/ | ||
|
||
import com.fasterxml.jackson.core.JsonGenerator; | ||
import com.fasterxml.jackson.databind.SerializerProvider; | ||
import com.fasterxml.jackson.databind.ser.std.StdScalarSerializer; | ||
import org.xrpl.xrpl4j.model.transactions.NetworkId; | ||
|
||
import java.io.IOException; | ||
|
||
/** | ||
* Custom Jackson serializer for {@link NetworkId}s. | ||
*/ | ||
public class NetworkIdSerializer extends StdScalarSerializer<NetworkId> { | ||
|
||
/** | ||
* No-args constructor. | ||
*/ | ||
public NetworkIdSerializer() { | ||
super(NetworkId.class, false); | ||
} | ||
|
||
@Override | ||
public void serialize(NetworkId networkId, JsonGenerator gen, SerializerProvider provider) throws IOException { | ||
gen.writeNumber(networkId.value().longValue()); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.