Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NfTokenBuyOffers and NfTokenSellOffers RequestParams/Results #465

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

nkramer44
Copy link
Collaborator

I noticed that there were some missing fields in NfTokenBuyOffersRequestParams, NfTokenBuyOffersResult, NfTokenSellOffersRequestParams and NfTokenSellOfferResult.

  • Both request params classes were missing a LedgerSpecifier field. I defaulted both of them to VALIDATED to keep the existing behavior
  • Both result classes were missing limit and marker fields, which made it impossible to page through results.
  • BuyOffer and SellOffer both had Amount and Flags as the @JsonProperty field names, but the actual json uses amount and flags. This wasn't actually an issue because Jackson seems to handle the wrong casing, but should be fixed regardless

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #465 (463b6a9) into main (7d72fdd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #465   +/-   ##
=========================================
  Coverage     90.46%   90.46%           
- Complexity     1468     1470    +2     
=========================================
  Files           287      287           
  Lines          4174     4176    +2     
  Branches        339      339           
=========================================
+ Hits           3776     3778    +2     
  Misses          277      277           
  Partials        121      121           
Files Changed Coverage Δ
...ava/org/xrpl/xrpl4j/model/client/nft/BuyOffer.java 100.00% <ø> (ø)
...pl/xrpl4j/model/client/nft/NftBuyOffersResult.java 100.00% <ø> (ø)
...l/xrpl4j/model/client/nft/NftSellOffersResult.java 100.00% <ø> (ø)
...va/org/xrpl/xrpl4j/model/client/nft/SellOffer.java 100.00% <ø> (ø)
...4j/model/client/nft/NftBuyOffersRequestParams.java 100.00% <100.00%> (ø)
...j/model/client/nft/NftSellOffersRequestParams.java 100.00% <100.00%> (ø)

Copy link
Collaborator

@sappenin sappenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nkramer44 nkramer44 merged commit d8b08f2 into main Aug 7, 2023
18 of 19 checks passed
@nkramer44 nkramer44 deleted the nk/fix-nft-offers branch August 7, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants