Fix NfTokenBuyOffers and NfTokenSellOffers RequestParams/Results #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there were some missing fields in
NfTokenBuyOffersRequestParams
,NfTokenBuyOffersResult
,NfTokenSellOffersRequestParams
andNfTokenSellOfferResult
.LedgerSpecifier
field. I defaulted both of them toVALIDATED
to keep the existing behaviorlimit
andmarker
fields, which made it impossible to page through results.BuyOffer
andSellOffer
both hadAmount
andFlags
as the@JsonProperty
field names, but the actual json usesamount
andflags
. This wasn't actually an issue because Jackson seems to handle the wrong casing, but should be fixed regardless