DRAFT: MPT Support #558
DRAFT: MPT Support #558
Conversation
…t a different approach to MptAmounts
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/MpTokenAuthorizeFlags.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/MpTokenFlags.java
Outdated
Show resolved
Hide resolved
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/MpTokenIssuanceCreateFlags.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Constant {@link MpTokenIssuanceFlags} for the {@code lsfMPTLocked} account flag. | ||
| */ | ||
| public static final MpTokenIssuanceFlags LOCKED = new MpTokenIssuanceFlags(0x00000001); |
There was a problem hiding this comment.
Let's discuss this one in particular.
There was a problem hiding this comment.
"this one" meaning LOCKED or MpTokenIssuanceFlags having an of(long) method?
xrpl4j-core/src/main/java/org/xrpl/xrpl4j/model/flags/MpTokenIssuanceSetFlags.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public MpTokenIssuanceId deserialize(JsonParser jsonParser, DeserializationContext ctxt) throws IOException { | ||
| return MpTokenIssuanceId.of(jsonParser.getText()); |
There was a problem hiding this comment.
Is this value expected to be in HEX? Just thinking out loud if MpTokenIssuanceId should be represented as a String in Java.
There was a problem hiding this comment.
I believe so? Isn't it the hash of the issuer address concatenated with the sequence?
| /** | ||
| * Custom Jackson serializer for {@link MpTokenObjectAmount}s. | ||
| */ | ||
| public class MpTokenObjectAmountSerializer extends StdScalarSerializer<MpTokenObjectAmount> { |
There was a problem hiding this comment.
Clarify what this object is?
There was a problem hiding this comment.
This is for MPT amounts that aren't MpTokenAmounts, ie for sfMaximumAmount, sfOutstandingAmount and sfMPTAmount. I have a separate type for all of these because they're UInt64s, but are serialized in JSON as base 10 rather than base 16.
To your comment below about if this could be replaced by MpTokenAmount, I don't see how that's possible, as MpTokenAmount holds the issuance ID as well as the amount. In the places MpTokenObjectAmounts show up, there isn't necessarily an issuance ID present
| Optional<AssetScale> assetScale(); | ||
|
|
||
| @JsonProperty("MaximumAmount") | ||
| Optional<MpTokenObjectAmount> maximumAmount(); |
There was a problem hiding this comment.
Is there any world where MpTokenObjectAmount can be replaced by MpTokenAmount (esp if this suggestion is taken)?
| ($) -> fail() | ||
| ); | ||
|
|
||
| void handleWithNulls() { |
There was a problem hiding this comment.
Note: Still need handleMpt, mapMpt, and maxMpt.
Deserialize mpt amounts as base 10
No description provided.