Open
Conversation
Seyedof
requested changes
Nov 7, 2024
Collaborator
Seyedof
left a comment
Seyedof
left a comment
There was a problem hiding this comment.
Thanks Kuba, few request changes
| @@ -0,0 +1,15 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
Please remove this file if it's something auto-generated
|
|
||
| Client() : curl_handle_(curl_easy_init()) { assert(curl_handle_ != nullptr); } | ||
| // Set Unix domain socket path | ||
| void SetUnixSocketPath(const std::string& socket_path) { |
Collaborator
There was a problem hiding this comment.
Better call it SetUnixDomainSocketPath
| #include <vector> | ||
|
|
||
| #include <cstddef> // for std::byte | ||
| #include <memory> // for std::allocator |
Collaborator
There was a problem hiding this comment.
Comments are redundant please remove
| template <typename ByteType = std::byte, | ||
| typename ByteTraits = std::char_traits<char>, // Default ByteTraits for char is used | ||
| typename Allocator = std::allocator<ByteType>> | ||
| class BasicResponseBuffer { |
Collaborator
There was a problem hiding this comment.
Nit style change, class and template better be at same indent level, (class is not inside template, no need to indent they are at same level)
| using string_type = std::basic_string<byte_type, byte_traits, allocator_type>; | ||
| typename ByteTraits = std::char_traits<ByteType>, | ||
| typename Allocator = std::allocator<ByteType>> | ||
| class BasicRequestHeader { |
Seyedof
approved these changes
Nov 12, 2024
Seyedof
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for Unix domain sockets (client)