Removing tensorflow-io-gcs-filesystem dependency #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #536 +/- ##
========================================
Coverage 90.09% 90.09%
========================================
Files 102 102
Lines 6252 6252
========================================
Hits 5633 5633
Misses 619 619 Continue to review full report in Codecov by Sentry.
|
ziofil
pushed a commit
that referenced
this pull request
Jan 22, 2025
**Context:** `tensorflow-io-gcs-filesystem` doesn't seem to be used by MrM (tested locally) and causes issues with Windows **Description of the Change:** removed `tensorflow-io-gcs-filesystem` from our list of dependencies **Benefits:** Fixed installation issues with Windows. Cleaner list of dependencies. **Possible Drawbacks:** Needs to be tested with other systems in case it is required somewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
tensorflow-io-gcs-filesystemdoesn't seem to be used by MrM (tested locally) and causes issues with WindowsDescription of the Change: removed
tensorflow-io-gcs-filesystemfrom our list of dependenciesBenefits: Fixed installation issues with Windows. Cleaner list of dependencies.
Possible Drawbacks: Needs to be tested with other systems in case it is required somewhere