Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for IGSN functionality by introducing new deposition models, collections, REST endpoints, and tests. Key changes include:
- Introducing DepositionModel, DepositionCollection, and PrefixCounter for handling IGSN operations.
- Updating navigation and REST route registrations to accommodate the new IGSN features.
- Extending settings and adding test suites to validate IGSN behavior.
Reviewed Changes
Copilot reviewed 47 out of 51 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| girder_jsonforms/web_client/models/index.js | Exporting the new DepositionModel. |
| girder_jsonforms/web_client/models/DepositionModel.js | New model for handling deposition metadata and IGSN logic. |
| girder_jsonforms/web_client/main.js | Added new navigation items for IGSN forms. |
| girder_jsonforms/web_client/collections/index.js | Exporting DepositionCollection along with other collections. |
| girder_jsonforms/web_client/collections/DepositionCollection.js | New collection for depositions with IGSN-specific sorting. |
| girder_jsonforms/tests/* | New tests for deposition flows and prefix counter behavior. |
| girder_jsonforms/settings.py | New IGSN-related settings and validators. |
| girder_jsonforms/rest/* | New REST endpoints and adjustments to support IGSN depositions. |
| girder_jsonforms/models/* | Updates to form and entry models for IGSN integration. |
| girder_jsonforms/lib/project_helpers.py | Helper functions for generating deposition indices. |
| girder_jsonforms/init.py | Updated plugin registration to include IGSN models and REST. |
Files not reviewed (4)
- girder_jsonforms/tests/data/gun_schema.json: Language not supported
- girder_jsonforms/tests/data/power_supply_schema.json: Language not supported
- girder_jsonforms/tests/data/target_schema.json: Language not supported
- girder_jsonforms/tests/data/target_source_schema.json: Language not supported
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
===========================================
+ Coverage 47.39% 63.42% +16.03%
===========================================
Files 10 19 +9
Lines 690 1873 +1183
===========================================
+ Hits 327 1188 +861
- Misses 363 685 +322 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tba