-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zh_Hans Localizations. And more. #482
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing the value in adding in the .hideInLocalizations
unless I'm missing something? Can you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In researching other localization issues - I came across Text(verbatim:
https://developer.apple.com/documentation/swiftui/text/init(verbatim:)
Which is a more simpler solution for what you're trying to accomplish so that it doesn't go into the .xcstrings file.
Can you remove your hideInLocalizations
variable and replace with verbatim where you want? Thanks
Got it! I will try it this weekend. |
I found that although Text support initializes with init(verbatim: ), Picker or TextField don't have alternatives for this. |
@MattKiazyk I removed "String+" and modified all Texts to use init(verbatim: ). For "Picker" and "TextField" and "Button" which are not supporting init(verbatim: ), I gave them labels with Texts. Please check it out. |
@megabitsenmzq thanks so much for those changes - can you just rebase and I'll get that merged in |
Done! |
Fix some old Localizations. All contains "前置步骤" -> "安装后准备步骤".
Remove old or useless Localizations.
Create a file "String+.swift" to remove preview strings from localizations. Make it easier to work on translation.Use Text(verbatim: ) to remove preview strings from localizations. Make it easier to work on translation.