Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: create required AD-groups in governance module #1252

Closed
wants to merge 3 commits into from

Conversation

landerss1
Copy link
Contributor

This PR adds support for creating required AD groups as part of the governance module, instead of having to create them manually in advance. The following AD-groups are now created automatically:

  • az-sub-<subscription_name>-all-owner
  • az-sub-<subscription_name>-all-contributor
  • az-sub-<subscription_name>-all-reader

Existing AD-groups must be imported using

terraform import module.governance_global.azuread_group.all_owner["delegate_sub_groups"] 00000000-0000-0000-0000-000000000000
terraform import module.governance_global.azuread_group.all_contributor["delegate_sub_groups"] 00000000-0000-0000-0000-000000000000
terraform import module.governance_global.azuread_group.all_reader["delegate_sub_groups"] 00000000-0000-0000-0000-000000000000

@landerss1
Copy link
Contributor Author

This PR overlooked the fact that these AD-groups are truly global across clusters, so they would be overwritten by other clusters usage of the governance modules. Closing.

@landerss1 landerss1 closed this Nov 14, 2024
@landerss1 landerss1 deleted the ad-groups branch November 20, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant