Breaking change: NZ Payroll PayTemplate method naming #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… getEmployeePayTemplate) in NZ Payroll API. Aligns the convention between UK & NZ Payroll, and the naming convention for other methods (endpoints are pluralised, methods are singular) Issue: XeroAPI/xero-ruby#173
|
Holding off on merging for now as this would be a breaking change |
|
Hey @rjaus We are closing this PR for now as it has been in open state for more than 3 years. Please take the latest changes from master and re-raise the PR if necessary. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NZ Payroll API: getEmployeePayTemplates method does not align with the overall method naming convention of the SDK, and differs from that of the same endpoint in the UK Payroll API.
Description
Release Notes
Standardises method naming convention between UK & NZ Payroll SDK's (same endpoint). Endpoint does not exist in the AU Payroll API or SDK.
XeroAPI/xero-ruby#173
This is a breaking change:
Requires references to
getEmployeePayTemplatesto change togetEmployeePayTemplatefor NZ Payroll API.Definitely affects the Ruby SDK. Will affect any other SDKs that name methods based on the operationId (possible all of them).
Screenshots (if appropriate):
Types of Changes