Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xero-payroll-uk.yaml #548

Closed
wants to merge 1 commit into from
Closed

Conversation

pumpkinball
Copy link
Contributor

Description

Update to xero-payroll-uk.yaml to add in niCategories as an array on Get Employee

Release Notes

Fixes Issue is PHP SDK 273

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@github-actions
Copy link

PETOSS-274

@github-actions
Copy link

Thanks for raising an issue, a ticket has been created to track your request

isOffPayrollWorker:
description: Whether the employee is an off payroll worker
type: boolean
Nicategories:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NiCategories

Copy link
Contributor

@RettBehrens RettBehrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abstract other instance of nicategory to $ref
make sure casing is consistent

@sangeet-joy-tw sangeet-joy-tw marked this pull request as draft October 7, 2024 03:06
@sangeet-joy-tw sangeet-joy-tw marked this pull request as ready for review October 21, 2024 04:31
@sangeet-joy-tw
Copy link
Contributor

Hey @pumpkinball

We are closing this PR for now as it has been in open state for more than a year now. Please take the latest changes from master and re-raise the PR if necessary.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants