fix: use correct deep link URL for bills (ACCPAY) when updating invoices #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating an invoice, the deep link URL was always using /invoicing/view/ regardless of the invoice type. For bills (ACCPAY invoices), this URL doesn't work correctly in Xero's web interface. This fix adds the same type-checking logic that already exists in the create invoice tool: bills (ACCPAY) now use DeepLinkType.BILL which generates the correct /bills/view/ URL path. Fixes XeroAPI#105
maxwellyoung
force-pushed
the
fix/bill-deeplink-url-105
branch
from
8bd68da to
1d43461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #105 - When updating an invoice, the deep link URL was always using
/invoicing/view/regardless of the invoice type. For bills (ACCPAY invoices), this URL does not work correctly in Xero's web interface.The fix: Added the same type-checking logic that already exists in
create-invoice.tool.tstoupdate-invoice.tool.ts:DeepLinkType.INVOICE→/invoicing/view/DeepLinkType.BILL→ correct bill URLChanges
Invoiceimport fromxero-nodeinvoice.typeand useDeepLinkType.BILLfor ACCPAY invoicesTest plan
npm run build)npm run lint)