Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skinning Goal: Update the precondition to avoid getting stuck #642

Closed
wants to merge 0 commits into from

Conversation

lionaneesh
Copy link

No description provided.

Comment on lines 74 to 75
AddPrecondition(GoapKey.incombat, false);
AddPrecondition(GoapKey.dangercombat, false);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be okay to use AddPrecondition(GoapKey.dangercombat, false);

  • That would mean that the player killed every known aggroed mob at the time. However anytime it can body pull a new mob.

However AddPrecondition(GoapKey.incombat, false); may add many extra seconds of delay due how the server sends out leave combat messages. Sometimes happens in a GCD(1.5s) sometimes takes like 5 seconds.

At this state i would not accept the PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes the mob can respawn right next to player while skinning this makes the player incombat; and I saw the bot kept on trying to skin while getting beaten by a mob and died.

Copy link
Owner

@Xian55 Xian55 Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case the GoapAgent already entered the SkinningGoal it will remain there indefinitely.

Probably it would be best to refactor the Update() loop to don't block the execution.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah. I can confirm this didn't fix it. I am now trying to add checks for combat inside the whileloop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants