Skip to content

[CI] Build shared libraries#473

Open
FabienPean-Virtonomy wants to merge 1 commit intomasterfrom
ci/use-shared-libs
Open

[CI] Build shared libraries#473
FabienPean-Virtonomy wants to merge 1 commit intomasterfrom
ci/use-shared-libs

Conversation

@FabienPean-Virtonomy
Copy link
Copy Markdown
Collaborator

@FabienPean-Virtonomy FabienPean-Virtonomy commented Nov 15, 2023

Generate shared libraries instead of static one. The objective is to reduce disk size consumed on the GitHub runners by the CI. Currently as static library, the binary code is duplicated many times across all example binaries. Building as shared library should solve that.

@Xiangyu-Hu
Copy link
Copy Markdown
Owner

The same problem with fontconfig:x64-osx.

@FabienPean-Virtonomy
Copy link
Copy Markdown
Collaborator Author

Does it reduce the memory consumption ?

@FabienPean-Virtonomy FabienPean-Virtonomy marked this pull request as ready for review November 24, 2023 10:06
@DrChiZhang
Copy link
Copy Markdown
Collaborator

Would you please give brief introduction of this PR?

@FabienPean-Virtonomy
Copy link
Copy Markdown
Collaborator Author

It is as per request from @Xiangyu-Hu who needs to have a smaller footprint on the CI disk consumption. A description has been briefly added. I leave it the rest to him.

@Xiangyu-Hu
Copy link
Copy Markdown
Owner

Something wrong with McOS ?

@FabienPean-Virtonomy
Copy link
Copy Markdown
Collaborator Author

The MacOS GitHub runner image is different between the build job and the test job.
20230921.1
20231115.2

The more recent version has Python 3.12, while the older is on 3.11, hence the break. I don't know why there is such discrepancy between runners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants