Open
Conversation
Owner
|
The same problem with fontconfig:x64-osx. |
Collaborator
Author
|
Does it reduce the memory consumption ? |
Collaborator
|
Would you please give brief introduction of this PR? |
Collaborator
Author
|
It is as per request from @Xiangyu-Hu who needs to have a smaller footprint on the CI disk consumption. A description has been briefly added. I leave it the rest to him. |
d95d8c3 to
2fb32c4
Compare
Owner
|
Something wrong with McOS ? |
Collaborator
Author
|
The MacOS GitHub runner image is different between the build job and the test job. The more recent version has Python 3.12, while the older is on 3.11, hence the break. I don't know why there is such discrepancy between runners. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate shared libraries instead of static one. The objective is to reduce disk size consumed on the GitHub runners by the CI. Currently as static library, the binary code is duplicated many times across all example binaries. Building as shared library should solve that.