VITIS-14540 - [MCDM] Provide interface for xrt-smi to disable frame boundary preemption. #8818
Open
zhangchiming wants to merge 3 commits intoXilinx:masterfrom
Open
VITIS-14540 - [MCDM] Provide interface for xrt-smi to disable frame boundary preemption. #8818zhangchiming wants to merge 3 commits intoXilinx:masterfrom
zhangchiming wants to merge 3 commits intoXilinx:masterfrom
Conversation
Signed-off-by: Chiming <chimingz@amd.com>
stsoe
reviewed
Mar 15, 2025
Collaborator
stsoe
left a comment
There was a problem hiding this comment.
Please address the clang-tidy warnings. Else everything is good.
Signed-off-by: Chiming <chimingz@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
Done. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Added the interface to enable/disable frame boundary preemption.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
xrt-smi need a interface to enable/disable frame boundary preemption..
How problem was solved, alternative solutions (if any) and why they were rejected
After this code change, a new escape code will be added to the NPU driver to enable/disable frame boundary preemption.
Risks (if any) associated the changes in the commit
N/A
What has been tested and how, request additional testing if necessary
Tested with the new escape code in NPU driver on Windows 11.
Documentation impact (if any)
N/A