AIESW-21287 add new qos parameter sleep_to_limit_fps#9540
Draft
mkorhone wants to merge 1 commit intoXilinx:masterfrom
Draft
AIESW-21287 add new qos parameter sleep_to_limit_fps#9540mkorhone wants to merge 1 commit intoXilinx:masterfrom
mkorhone wants to merge 1 commit intoXilinx:masterfrom
Conversation
Author
|
This PR should be considered experimental and useful to start a discussion on the value of this feature. There are a few TODOs documented in the code changes that should be addressed prior to considering merging this. In the meantime, this PR can be used internally as needed by developers that benefit from this new feature. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| { | ||
| // Initialize target frame time if sleep_to_limit_fps is enabled | ||
| if (m_profile->m_sleep_to_limit_fps && m_profile->m_target_fps > 0) | ||
| m_target_frame_time_ns = 1'000'000'000ULL / m_profile->m_target_fps; |
Contributor
There was a problem hiding this comment.
warning: 1'000'000'000ULL is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers]
m_target_frame_time_ns = 1'000'000'000ULL / m_profile->m_target_fps;
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Add new qos parameter
sleep_to_limit_fpsto profile.json that can be used to simulate a model running at a fixed frame rateBug / issue (if any) fixed, which PR introduced the bug, how it was discovered
N/A
How problem was solved, alternative solutions (if any) and why they were rejected
Alternative solution is to use the existing
sleepparameter in theiterationnode inexecutions. This sleep duration is fixed, but since the sleep amount varies based on what else is running, it seems less brittle to automatically compute the sleep duration.Risks (if any) associated the changes in the commit
None unless this new parameter is used. Otherwise, we should consider this parameter experimental.
What has been tested and how, request additional testing if necessary
Ran full model tests both with and without this new parameter
Documentation impact (if any)
Potentially could document this new parameter