Attempt to define Python 3.12 as baseline for pybind11 compatibility#9720
Open
sonals wants to merge 1 commit intoXilinx:masterfrom
Open
Attempt to define Python 3.12 as baseline for pybind11 compatibility#9720sonals wants to merge 1 commit intoXilinx:masterfrom
sonals wants to merge 1 commit intoXilinx:masterfrom
Conversation
Signed-off-by: Sonal Santan <sonal.santan@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Remove strong dependency of pybind module on the version of python it was compiled with.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
None
How problem was solved, alternative solutions (if any) and why they were rejected
Define Py_LIMITED_API to 3.12 version when compiling pybind11 module
Risks (if any) associated the changes in the commit
Requires qualification across different python versions.
What has been tested and how, request additional testing if necessary
Need to build and test with different python versions.
Documentation impact (if any)
None