-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel Examples: Worker-to-self, Worker-to-worker #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… so made herd_to_herd standalone too. Also updated docs
hunhoffe
changed the title
Channel Example: Worker-to-worker
WIP - Channel Examples: Worker-to-self, Worker-to-worker
Jul 9, 2024
hunhoffe
changed the title
WIP - Channel Examples: Worker-to-self, Worker-to-worker
Channel Examples: Worker-to-self, Worker-to-worker
Jul 10, 2024
erwei-xilinx
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An example using mlir-air Channels to send data between two workers. Part of #648
Also created an example of worker-to-self that currently does not work, but submitting with expected failure in the lit test. This corresponds to issue: #654
I was also unable to get worker-to-worker working correctly. It's possible it's my own bug in some way I haven't reasoned through (it could probably use a good reviewing by a second set of eyes). I created an issue for this too: #660