Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus/clique: add some missing checks (#22836) #474

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

wanwiset25
Copy link
Collaborator

@wanwiset25 wanwiset25 commented Mar 5, 2024

Proposed changes

Add checks to make sure gasLimit is within valid range as advised by the auditing team.
ref: ethereum#22836

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

consensus/clique/clique.go Outdated Show resolved Hide resolved
@wanwiset25
Copy link
Collaborator Author

I updated the logic to match the current go-eth code.

Thanks for the suggestion @gzliudan

@wjrjerome
Copy link
Collaborator

We actually don't need to do any work for the clique consensus. it's not been used anywhere.

@wanwiset25 wanwiset25 merged commit 77390d3 into dev-upgrade Mar 26, 2024
34 checks passed
@wanwiset25 wanwiset25 deleted the COS-02 branch March 26, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants