Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DB Is Closed Before The Client Exit #476

Closed
wants to merge 2 commits into from
Closed

Conversation

wanwiset25
Copy link
Collaborator

Proposed changes

Before exiting the XDC application using command lines, close the database to prevent any potential storage collisions.
This change is advised by the auditing team.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)
    CMD

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copy link
Collaborator

@gzliudan gzliudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

	chainDb.Close()
	return nil

The last chainDb.Close() should be removed

@wanwiset25
Copy link
Collaborator Author

	chainDb.Close()
	return nil

The last chainDb.Close() should be removed

Thanks, pls check again

@wanwiset25 wanwiset25 requested a review from gzliudan March 5, 2024 14:19
@gzliudan
Copy link
Collaborator

gzliudan commented Mar 5, 2024

Please merge your 2 commits into 1 commit since one of them has problem.

@wanwiset25 wanwiset25 closed this Mar 5, 2024
@wanwiset25 wanwiset25 deleted the XCX-03 branch March 5, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants