Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert future blocks check behavior for v1 engine #531

Merged
merged 1 commit into from
May 13, 2024

Conversation

wanwiset25
Copy link
Collaborator

@wanwiset25 wanwiset25 commented May 10, 2024

revert future blocks check behavior for v1 engine due to sync issue
ref: #497

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@wanwiset25 wanwiset25 changed the title revert https://github.com/XinFinOrg/XDPoSChain/pull/497 behavior for v1 engine revert future blocks check behavior for v1 engine May 10, 2024
@wjrjerome wjrjerome merged commit 2bbecdc into dev-upgrade May 13, 2024
34 checks passed
@wjrjerome wjrjerome deleted the fix-sync-v1 branch May 13, 2024 11:26
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 18, 2024
This was referenced Jul 18, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 26, 2024
wanwiset25 pushed a commit that referenced this pull request Jul 30, 2024
wanwiset25 pushed a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants