Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Linka's pulls #136

Merged
merged 18 commits into from
Jun 18, 2023
Merged

Linka's pulls #136

merged 18 commits into from
Jun 18, 2023

Conversation

Xlinka
Copy link
Owner

@Xlinka Xlinka commented May 14, 2023

No description provided.

Frozenreflex
Frozenreflex suggested changes May 14, 2023
View reviewed changes
Copy link
Collaborator

@Frozenreflex Frozenreflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest changes to RandomEulerAngles to make it evenly distributed, but it has min and max values for each component and I'm not sure how that'd be done with even distribution.
I don't know what HMAC is, and I have no idea how the Yahoo finance api works, so I'm going to assume you made it work properly.

NEOSPlus/Logix/Users/Is User Eye Tracking.cs Outdated Show resolved Hide resolved
@Xlinka
Copy link
Owner Author

Xlinka commented May 14, 2023

I would suggest changes to RandomEulerAngles to make it evenly distributed, but it has min and max values for each component and I'm not sure how that'd be done with even distribution. I don't know what HMAC is, and I have no idea how the Yahoo finance api works, so I'm going to assume you made it work properly.

they both work hmac is basically encryption methods similar to TOTP requested by @Lexevolution

@Xlinka
Copy link
Owner Author

Xlinka commented Jun 15, 2023

Will do full testing later with someone for the vive nodes and will refactor and fix the issues with the other code when I land from this plane.

@Xlinka
Changes Made
3dbbb0d 
Changes Made
@Xlinka
Copy link
Owner Author

Xlinka commented Jun 16, 2023

@Frozenreflex @dfgHiatus changes made

@Xlinka
Update Is User Eye Tracking.cs
2b42f2d 
Fixing the issue of breaking on users without
@Xlinka
Update Color to CMYK.cs
2311ef3 
beep boop
Frozenreflex
Frozenreflex suggested changes Jun 17, 2023
View reviewed changes
NEOSPlus/Logix/Input Devices/ViveTrackerByBodyNode.cs Outdated Show resolved Hide resolved
NEOSPlus/Logix/Color/Color to CMYK.cs Outdated Show resolved Hide resolved
NEOSPlus/Logix/Network/Get Stock Price.cs Outdated Show resolved Hide resolved
NEOSPlus/Logix/Users/Is User Eye Tracking.cs Outdated Show resolved Hide resolved
NEOSPlus/Logix/Color/Color to CMYK.cs Outdated Show resolved Hide resolved
NEOSPlus/Logix/Input Devices/TrackerBatteryBase.cs Show resolved Hide resolved
@Xlinka
Copy link
Owner Author

Xlinka commented Jun 18, 2023

Removed CYMK node for now

@Xlinka Xlinka merged commit a537e6c into main Jun 18, 2023
@Xlinka Xlinka deleted the Linka's-Pulls branch June 26, 2023 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Frozenreflex Frozenreflex Frozenreflex requested changes

@dfgHiatus dfgHiatus Awaiting requested review from dfgHiatus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xlinka @Frozenreflex @dfgHiatus @art0007i