Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Update HTTPRequest.cs #141

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Update HTTPRequest.cs #141

merged 1 commit into from
Jul 23, 2023

Conversation

Xlinka
Copy link
Owner

@Xlinka Xlinka commented Jul 17, 2023

Updated HTTP NODE to use one HTTP CLIENT instead of instantiating a new one for each pulse

Updated HTTP NODE to use one HTTP CLIENT instead of instantiating a new one for each pulse
@Xlinka Xlinka removed the request for review from Frozenreflex July 17, 2023 21:33
@Xlinka
Copy link
Owner Author

Xlinka commented Jul 17, 2023

@Lexevolution

@Lexevolution
Copy link
Contributor

I couldn't see why #131 was happening, since I was only reusing the CloudXInterface.SafeHTTPClient, which is the same httpClient that's used in the vanilla GET and POST string nodes. But if changing it to its own httpClient fixes the problem, then I guess it's fine.

@Xlinka
Copy link
Owner Author

Xlinka commented Jul 20, 2023

Maybe we should add a neosplus safehttp client for neosplus usage?

@Lexevolution
Copy link
Contributor

The only difference between the regular one and the "safe" one is that the "safe" one has a one minute timeout. Which can just be added by putting

client.Timeout = TimeSpan.FromMinutes(1);

directly after this.

@Xlinka
Copy link
Owner Author

Xlinka commented Jul 21, 2023

Odd

@Xlinka
Copy link
Owner Author

Xlinka commented Jul 23, 2023

merging since it fixes issue will update if anything else arrises

@Xlinka Xlinka merged commit d36914f into main Jul 23, 2023
@Xlinka Xlinka deleted the Testing branch September 4, 2023 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants